Skip to content

chore(language-server): integrate LS - #7164

Open
team-ide-user wants to merge 1 commit into
mainfrom
chore/automatic-upgrade-of-ls
Open

chore(language-server): integrate LS#7164
team-ide-user wants to merge 1 commit into
mainfrom
chore/automatic-upgrade-of-ls

Conversation

@team-ide-user

@team-ide-user team-ide-user commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Changes since last integration of Language Server

commit a8fa156bbca577c9ce41319698ebe37b65f453ef
Author: Ben Durrans <Benjamin.Durrans@snyk.io>
Date:   Fri Aug 21 17:39:24 2026 +0100

    refactor: log delta pre-filter before/after counts in FilterIssues [IDE-2477] (#1412)
    
    `filterIssuesWithConfig` applies a delta pre-filter (`filterByIsNew`) ahead of its reason-counted filter loop, so an issue set emptied there produced no distinguishing log line — a debug log could show "No issues were filtered out" while diagnostics came out empty, with no way to tell why.
    
    Folds the drop count into the existing `filterReasonCounts` mechanism via a new `FilterReasonNotNetNew` reason, computed only when delta filtering is enabled. `filterByIsNew` now classifies and counts dropped issues in the same pass it filters them (returning `(snyk.IssuesByFile, int)`) rather than diffing two separate before/after counts; nil entries are skipped without being counted as a drop. `GetDelta`, `filterByIsNew`'s other caller, discards the count. Both `filterReasonCounts` log lines now also carry a `deltaEnabled` field.
    
    Also adds direct coverage for `filterByIsNew`'s filtered/dropped return values (including the nil-skip case), and for the previously-untested direction of `FilterIssues` where a non-new issue passes through when delta filtering is disabled.

M	domain/ide/workspace/folder.go
M	domain/ide/workspace/folder_test.go

commit 07e8f4e3676d1382a8d87760d3712a6215fb10df
Author: Andrew Robinson Hodges <andrew.robinsonhodges@snyk.io>
Date:   Fri Aug 21 12:10:53 2026 +0100

    fix: link secrets rule ids to documentation [IDE-2329] (#1403)

M	application/server/server.go
M	application/server/unified_test_api_smoke_test.go
M	domain/ide/converter/converter.go
M	domain/ide/converter/converter_test.go
M	infrastructure/secrets/convert.go
M	infrastructure/secrets/convert_test.go
M	infrastructure/sentry/sentry_error_reporter_test.go
M	internal/notification/notification_test.go
M	internal/notification/notifier.go
M	internal/notification/notifier_mock.go
M	internal/types/lsp.go

@team-ide-user
team-ide-user requested a review from a team as a code owner August 21, 2026 11:16
@snyk-io

snyk-io Bot commented Aug 21, 2026

Copy link
Copy Markdown

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues
Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@github-actions

github-actions Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor
Warnings
⚠️

"chore: automatic integration of language server a8fa156bbca577c9ce41319698ebe37b65f453ef" is too long. Keep the first line of your commit message under 72 characters.

Generated by 🚫 dangerJS against ea35f3b

@snyk-pr-review-bot

This comment has been minimized.

@team-ide-user
team-ide-user force-pushed the chore/automatic-upgrade-of-ls branch from 6d6f0cf to ea35f3b Compare August 21, 2026 16:45
@snyk-pr-review-bot

Copy link
Copy Markdown

PR Reviewer Guide 🔍

🧪 No relevant tests
🔒 No security concerns identified
⚡ No major issues detected
📚 Repository Context Analyzed

This review considered 4 relevant code sections from 4 files (average relevance: 1.00)

🤖 Repository instructions applied (from AGENTS.md)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant