fix: bump bundled semver past ReDoS vuln in ts-binary-wrapper - #7166
Open
nick-y-snyk wants to merge 1 commit into
Open
fix: bump bundled semver past ReDoS vuln in ts-binary-wrapper#7166nick-y-snyk wants to merge 1 commit into
nick-y-snyk wants to merge 1 commit into
Conversation
global-agent (bundled into the published snyk npm package) depends on semver@^7.3.2, which was locked at the vulnerable 7.3.8 (SNYK-JS-SEMVER-3247795, GHSA-c2qf-rxjj-qqgw). The .snyk ignore for this finding expired 2024-09-13 and was never renewed. Add an override pinning semver to ^7.5.2+ under global-agent and refresh just that subtree via `npm update semver`, so every published snyk CLI build (stable and preview) ships the patched version.
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
PR Reviewer Guide 🔍
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
global-agent(bundled into the publishedsnyknpm package viats-binary-wrapper'sbundleDependencies) depends onsemver@^7.3.2, locked at the vulnerable7.3.8(SNYK-JS-SEMVER-3247795 / GHSA-c2qf-rxjj-qqgw, ReDoS)..snykignore for this finding expired 2024-09-13 and was never renewed.overridesentry pinningsemverto^7.5.2underglobal-agent, refreshed vianpm update semver(scoped diff, no unrelated dependency drift).snykCLI build (stable and preview) will ship the patched semver once this merges and a new version is cut.Test plan
npm testints-binary-wrapper— 33/33 passingsnyk-axi testagainst the patched tree — SNYK-JS-SEMVER-3247795 no longer present