optimization: move some instructions out of the argent-device-interact skill to reference files - #968
Open
kasperski95 wants to merge 5 commits into
Open
optimization: move some instructions out of the argent-device-interact skill to reference files#968kasperski95 wants to merge 5 commits into
kasperski95 wants to merge 5 commits into
Conversation
kasperski95
changed the title
kasperski95
marked this pull request as ready for review
August 26, 2026 15:39
latekvo
reviewed
Aug 31, 2026
Member
There was a problem hiding this comment.
The sub total of text has grown past the size of the moved text.
Not necessarily bad but kind of misses the point of this PR, if these new things are useful then just change the PR description and we're good.
Left couple inlines. Good job and thx for it.
Member
There was a problem hiding this comment.
chromium.md duplicates text that was never removed from SKILL.md
SKILL.md:24- "gesture-swipe is touch-only, use gesture-scroll" - still there, repeated in the new textSKILL.md:59-60- the scroll/drag table - still there; chromium.md repeats it minus the "(Chromium)" column labelsSKILL.md:185- "paste … Chromium and Vega are rejected" - still there, repeatedSKILL.md:169-"delayMs … applies to the iOS simulator and Chromium" - still there, repeatedSKILL.md:285- the run-sequence allowlist already contains both tools; chromium-tabs.md restates it as prose
| ## Unified tool surface | ||
|
|
||
| All interaction tools below accept a `udid` parameter and auto-dispatch iOS vs Android based on its shape (UUID → iOS simulator, `chromium-cdp-<port>` → Chromium (CDP) app, anything else → Android adb serial). You use the same tool names on every platform. | ||
| All interaction tools below accept a `udid` parameter and auto-dispatch on its shape, so you use the same tool names on every platform. A known prefix wins first — `chromium-cdp-` → Chromium (CDP) app, `remote:` → remote iOS simulator — otherwise a bare UUID → local iOS simulator and anything else → Android adb serial. |
Member
There was a problem hiding this comment.
This fact is completely new. Nothing bad just pointing it out since it's out of scope of this PR.
|
|
||
| ## What counts as a Chromium target | ||
|
|
||
| A **Chromium (CDP) app** = any Chromium runtime exposing a Chrome DevTools Protocol endpoint: an Electron app (boot it with `boot-device` + `electronAppPath`), or any Chromium-family browser (Chrome/Brave/Edge) launched with `--remote-debugging-port`. The latter is auto-discovered by `list-devices` on port `9222` plus anything in `ARGENT_CHROMIUM_PORTS` — already-running browsers show up directly, no `boot-device` needed. The same describe/tap/swipe/keyboard/screenshot surface drives all of them. |
Member
There was a problem hiding this comment.
Also new, not on main, just pointing out.
| ### await-ui-element — Block until a UI element reaches a state | ||
|
|
||
| Instead of polling `screenshot`/`describe` in a loop, use `await-ui-element` to block server-side until an element reaches an expected state (or `timeoutMs`, default 5000ms, elapses). It polls the same accessibility/DOM tree as `describe`. (For a plain pause, use your own harness sleep — this tool deliberately has no bare-timer mode.) | ||
| **Never poll `screenshot`/`describe` in a loop to wait for something.** Use `await-ui-element`: it blocks server-side on the same tree `describe` reads. It has no bare-timer mode by design — for a plain pause, use your own harness sleep. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Skills are getting bloated affecting benchmark results.
What
<SKILL>/references/chromium.md— no point of loading that information to the context when argent is used with iOS or Android<SKILL>/references/secrets.md— typing secrets is rather unusual.Note
Not tested. Relying on CI.