feat: support HTML line break tags - #700
Open
huytdps13400 wants to merge 1 commit into
Open
Conversation
eszlamczyk
reviewed
Aug 26, 2026
eszlamczyk
left a comment
Collaborator
There was a problem hiding this comment.
Hi @huytdps13400 we will have to investigate this feature further if this is the way we are 100% sure we want to take, I'll circle to it back in the future
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What/Why?
Support attribute-free HTML line break tags (
<br>,<br/>,<br />, including case variants) in the shared Markdown parser.The parser previously disabled all HTML tokenization, so these tags were emitted as literal text. This change keeps HTML blocks disabled, enables inline HTML tokenization, maps only supported
brtokens to the existingLineBreakAST node, and appends every other inline HTML token as literal text. Tags with attributes and tags inside code spans remain literal.This also covers
brinside GFM table cells.Closes #52.
Testing
EnrichedMarkdownXCTest suite on iPhone 17 Pro simulatoryarn lintyarn typecheckyarn test— 6/6 testsyarn preparePR Checklist