feat(ios): copy selected markdown as verbatim source - #720
Draft
maksg wants to merge 2 commits into
Draft
Conversation
Partial-selection Copy as Markdown now returns a byte-faithful slice of the original source instead of a normalized reconstruction. A Swift-side SourceOffsetAnnotator maps text nodes (including escapes and structural thematic breaks) to UTF-8 byte ranges after parsing, the renderer copies them onto runs and attachment characters, and the extractor unions the selected runs' ranges, expands over adjacent syntax (inline markers, block prefixes, code fences, table rows, image syntax, setext underlines), and re-validates every slice by parsing it — any mapping defect falls back to reconstruction, never wrong clipboard content. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Fold image handling into EdgeTrait and share one marker-consumption loop between both slice edges, extract line-boundary helpers, reuse the extractor's InlineTraits and invisible-character set instead of re-deriving them, tag runs through one shared helper, and carry the rendered source and its parse flags as a single RenderedSource value so they can never pair up stale. No behavior change. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What/Why?
Testing
PR Checklist