feat(web): render the input model into the editable dom - #734
Draft
sbarczyk wants to merge 4 commits into
Draft
Conversation
sbarczyk
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the renderer layer of the web input: the model (plain-text buffer + formatting and block ranges) is projected into paragraphs with style runs and written into the editable DOM with a minimal diff.
InputProjection:computeStyleRunsflattens overlapping formatting ranges into disjoint runs (boundary-event sweep, same idiom as the serializer);projectParagraphssplits the buffer into per-line paragraphs with block metadata, with zero-length anchors claiming their line.DomRenderer: canonical DOM shape (one div per paragraph, one span per run,<br>in empty lines, links as spans withdata-url). Updates mutate existing nodes in place (nodeValue,className) so the caret and IME are never disturbed, and a prefix/suffix window diff keeps a single edit down to a single DOM mutation.inputStyles: stylesheet generated from the shared defaults (DEFAULT_NORMALIZED_STYLE, the input style normalizer, heading and list constants from the model). List markers are drawn via::beforefromdata-depth/data-ordinal, mirroring the native marker drawer. Base typography is a temporary stand-in until thestyleprop arrives with the JS API layer.Jest unit tests cover the projection; the renderer will be exercised end to end by the Playwright flow tests arriving with the editing shell. Stacked on #727.