-
Notifications
You must be signed in to change notification settings - Fork 64
feat: add onImagePress event to EnrichedText #681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kacperzolkiewski
wants to merge
17
commits into
main
Choose a base branch
from
@kacperzolkiewski/feat-on-image-press
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
ffd3c2b
feat: add onImagePress event to EnrichedText
kacperzolkiewski 639bb1c
test: add e2e test for onPressImage event
kacperzolkiewski 087b3eb
test: fix screenshots
kacperzolkiewski 0c06545
docs: add docs for onImagePress event
kacperzolkiewski ab54ab2
Merge branch 'main' into @kacperzolkiewski/feat-on-image-press
kacperzolkiewski 482fcc0
Merge branch 'main' into @kacperzolkiewski/feat-on-image-press
kacperzolkiewski e80079b
feat(web): onImagePress (#690)
hejsztynx c02de63
Merge branch 'main' into @kacperzolkiewski/feat-on-image-press
kacperzolkiewski 06f631f
Merge branch 'main' into @kacperzolkiewski/feat-on-image-press
kacperzolkiewski a88ebb8
Merge branch 'main' into @kacperzolkiewski/feat-on-image-press
kacperzolkiewski 73061e8
fix: update docs
kacperzolkiewski 9b23270
Apply suggestion from @kacperzolkiewski
kacperzolkiewski 1fae618
Merge branch 'main' into @kacperzolkiewski/feat-on-image-press
hejsztynx 685b8ad
docs: revert docs update
hejsztynx 63e9ad8
Revert "docs: revert docs update"
hejsztynx e30bca8
fix(web): emit onImagePress when src is empty
hejsztynx a257e2b
refactor: duplicated css
hejsztynx File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| appId: swmansion.enriched.example | ||
| --- | ||
| # Validates that image press events are triggered correctly | ||
| - launchApp | ||
|
|
||
| - tapOn: | ||
| id: 'toggle-screen-button' | ||
|
|
||
| - tapOn: | ||
| id: 'toggle-enriched-text-screen-button' | ||
|
|
||
| - runFlow: | ||
| file: '../subflows/set_enriched_text_value.yaml' | ||
| env: | ||
| VALUE: '<html><img src="https://picsum.photos/id/1/200/200" width="200" height="200"/></html>' | ||
|
|
||
| - tapOn: | ||
| id: 'enriched-text' | ||
| point: '5%,50%' | ||
|
|
||
| - runFlow: | ||
| file: '../subflows/capture_or_assert_screenshot.yaml' | ||
| env: | ||
| SCREENSHOT_NAME: 'image_press' |
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
29 changes: 29 additions & 0 deletions
29
android/src/main/java/com/swmansion/enriched/text/events/OnImagePressEvent.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| package com.swmansion.enriched.text.events | ||
|
|
||
| import com.facebook.react.bridge.Arguments | ||
| import com.facebook.react.bridge.WritableMap | ||
| import com.facebook.react.uimanager.events.Event | ||
|
|
||
| class OnImagePressEvent( | ||
| surfaceId: Int, | ||
| viewId: Int, | ||
| private val uri: String, | ||
| private val width: Double, | ||
| private val height: Double, | ||
| ) : Event<OnImagePressEvent>(surfaceId, viewId) { | ||
| override fun getEventName(): String = EVENT_NAME | ||
|
|
||
| override fun getEventData(): WritableMap? { | ||
| val eventData: WritableMap = Arguments.createMap() | ||
| val imageMap = Arguments.createMap() | ||
| imageMap.putString("uri", uri) | ||
| imageMap.putDouble("width", width) | ||
| imageMap.putDouble("height", height) | ||
| eventData.putMap("image", imageMap) | ||
| return eventData | ||
| } | ||
|
|
||
| companion object { | ||
| const val EVENT_NAME: String = "onImagePress" | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.