chore: next 16 turbopack 빌드 전환#534
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f18f9b85ee
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "typecheck:ci": "tsc --noEmit -p tsconfig.ci.json", | ||
| "ci:check": "pnpm run lint:check && pnpm run typecheck:ci", | ||
| "analyze": "ANALYZE=true next build --webpack" | ||
| "analyze": "ANALYZE=true next build" |
There was a problem hiding this comment.
Changing analyze to ANALYZE=true next build breaks the intended bundle-report workflow because this repo uses @next/bundle-analyzer in next.config.mjs, and that plugin is webpack-based while Turbopack does not run webpack plugins. In practice, running the analyze script after this commit will no longer produce the analyzer report that previously appeared with next build --webpack, so size-regression checks become silently ineffective.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
반영했습니다. 기본 build는 Turbopack(next build)으로 유지하고, @next/bundle-analyzer가 webpack plugin 기반인 점을 고려해 analyze는 ANALYZE=true next build --webpack으로 되돌렸습니다. pnpm --filter @solid-connect/web analyze도 실행해 .next/analyze/{client,nodejs,edge}.html 리포트 생성까지 확인했습니다.
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f548ec516e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "scripts": { | ||
| "dev": "next dev", | ||
| "build": "next build --webpack", | ||
| "build": "next build", |
There was a problem hiding this comment.
--webpack in the build script
Switching apps/web to "build": "next build" enables Turbopack by default in Next 16, but this app still defines a custom webpack function in apps/web/next.config.mjs (lines 59-83). In this configuration, next build fails when a webpack config is present, so the standard pnpm --filter @solid-connect/web build path can break in CI/release builds. Keep --webpack until the webpack block is removed/migrated, or explicitly migrate to a Turbopack-only config path.
Useful? React with 👍 / 👎.
1 participant
관련 이슈
작업 내용
apps/web의 production build를next build --webpack에서 Next 16 기본next build로 되돌렸습니다.next.config.mjs에turbopack.rules를 추가했습니다.@svgr/webpack을 Turbopack loader로 연결해 기존@svgr/webpack기반 SVG 사용 방식을 유지합니다.특이 사항
16.2.6이라 추가 버전 상승은 없습니다. 이 PR은 Next 16 기본 빌더인 Turbopack 호환성 전환입니다.리뷰 요구사항 (선택)
rules설정이 기존 SVG import 사용처와 호환되는지 중점적으로 봐주세요.검증
pnpm --filter @solid-connect/web buildpnpm --filter @solid-connect/web lint:checkpnpm --filter @solid-connect/web typecheckpnpm --filter @solid-connect/web ci:check