HLD: Front Panel Port LED Policy - #2223
Conversation
|
/azp run |
|
No pipelines are associated with this pull request. |
Signed-off-by: Justin Oliver <justinoliver@arista.com>
3a7dc2f to
f063f7f
Compare
|
/azp run |
|
No pipelines are associated with this pull request. |
pfallon-nexthop
left a comment
pfallon-nexthop
left a comment
There was a problem hiding this comment.
Thanks Justin! I just had a question for the policy when it comes to adaptors.
|
|
||
| A front panel port will have 0 to N LEDs associated with it. The LED policy will evenly split the logical interfaces of a front panel port across the available LEDs. If the number of LEDs exceeds the number of logical interfaces, the extra LEDs will remain off. | ||
|
|
||
| For example, an OSFP port with 2 LEDs: |
There was a problem hiding this comment.
Can you please clarify what would be the behavior for an OSFP port with 2 LEDs if a QSFP Adaptor is inserted?
In this case there would only be 4 usable lanes. Based on the stated policy, I would expect the two LEDs to split the interfaces on the first 4 lanes between them. However, this means the physical lanes the LED pertains to for status will change with an adaptor, which could add some complexity and may be confusing.
There was a problem hiding this comment.
Hi Paul! The current plan is to distribute the usable lanes across the LEDs. As you pointed out, the mapping will be somewhat dynamic when adaptors are used but I hope the new CLI command makes it very clear which lanes map to which LEDs.
There was a problem hiding this comment.
Thanks Justin! That seems reasonable to me. I think it would be helpful to add one example along these lines.
|
@judyjoseph Can you help review? |
|
I've create sonic-net/sonic-platform-common#662 which has the platform API changes to support the new policy. |
5 participants
Add a HLD describing a new policy for front panel LEDs. This proposal defines consistent behavior for port LEDs and moves the LED state/color logic out of the platform layer and into LEDD daemon. The proposal covers breakout scenarios and how to map subports to 1 or more port LEDs.