[action/cherry-pick][sonic_xcvr] Fix firmware download TypeError - #745
Merged
Conversation
Signed-off-by: Pavan Kalyan Nakka <pnakka@microsoft.com> (cherry picked from commit c07f074)
Collaborator
|
/azp run |
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
Contributor
Author
|
@vaibhavhd can you please help approve this cherry-pick PR? Thanks |
vaibhavhd
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Cherry-pick of #744 to 202605.
Motivation and Context
There is a cherry-pick conflict, so manually creating PR for backport.
How Has This Been Tested?
On version 202605:
Hardware: Reproduced the TypeError on the unpatched code, then confirmed firmware download proceeds past block-write with the fix applied.
Unit tests: pytest tests/sonic_xcvr/test_cdb_fw.py
Additional Information (Optional)