Skip to content

Add SFF-8024 Rev 4.14 LRO (RTLR) AppSel host electrical interface codes - #749

Open
bobby-nexthop wants to merge 1 commit into
sonic-net:masterfrom
nexthop-ai:sff8024-lro-appsel-codes
Open

Add SFF-8024 Rev 4.14 LRO (RTLR) AppSel host electrical interface codes#749
bobby-nexthop wants to merge 1 commit into
sonic-net:masterfrom
nexthop-ai:sff8024-lro-appsel-codes

Conversation

@bobby-nexthop

@bobby-nexthop bobby-nexthop commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Description

Adds the four LRO (linear-receive optics) AppSel host electrical interface IDs introduced in SFF-8024 Rev 4.14 Table 4-5 to sonic_platform_base/sonic_xcvr/codes/public/sff8024.py:

ID Hex Host Electrical Interface Bit rate (Gb/s) Lanes Baud (GBd)
152 98 EEI-200G-RTLR-1 212.5 1 106.25
153 99 EEI-400G-RTLR-2 425 2 106.25
154 9A EEI-800G-RTLR-4 850 4 106.25
155 9B EEI-1.6T-RTLR-8 1700 8 106.25

These are the 106.25 GBd/lane siblings of the 53.125 GBd EEI-*-RTLR-*-S/L codes 144-151 that are already in the table. Values transcribed from SFF-8024 Rev 4.14 (published 2026-06-04), Table 4-5, page 27.

Nothing else changes: no MODULE_MEDIA_TYPE / media-interface entries are touched, and CmisApi.LPO_HOST_ELECTRICAL_INTERFACE_IDS is deliberately left alone as LRO is not LPO, and codes 144-151 aren't in that list either. In a future PR I'll ad something similar to the CmisAPI

Motivation and Context

Without these entries, a module advertising an LRO application in its AppSel table decodes to Unknown in get_application_advertisement() and everything downstream of it (sfputil, TRANSCEIVER_INFO, xcvrd application selection).

How Has This Been Tested?

Static verification only — no LRO module on hand:

  • Parsed the modified dict via ast.literal_eval, confirmed no duplicate keys, and 152-155 resolve to the names above.
  • Cross-checked every existing 144-151 name against Rev 4.14 Table 4-5.

One pre-existing discrepancy spotted while cross-checking, not fixed here
to keep this diff to the requested change: SM_MEDIA_INTERFACE[147] is
'800G-FR4-LPO', but Rev 4.14 Table 4-8 lists code 147 (0x93) as 400G-FR4-LPO. Can fix in a follow-up if desired.

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

@linux-foundation-easycla

linux-foundation-easycla Bot commented Aug 27, 2026

Copy link
Copy Markdown

CLA Signed
The committers listed above are authorized under a signed CLA.

  • ✅ login: bobby-nexthop / name: Bobby McGonigle (f721d5f)

@mssonicbld

Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).

@bobby-nexthop
bobby-nexthop force-pushed the sff8024-lro-appsel-codes branch from 0fe82c5 to f721d5f Compare August 27, 2026 16:43
@mssonicbld

Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).

@bobby-nexthop
bobby-nexthop marked this pull request as ready for review August 27, 2026 16:43
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

@bobby-nexthop

Copy link
Copy Markdown
Contributor Author

@prgeor

Adds host electrical interface IDs 152-155 from SFF-8024 Rev 4.14
Table 4-5 (EEI-*-RTLR-* at 106.25 GBd/lane) so LRO application
advertisements decode instead of falling through to Unknown.

Signed-off-by: Bobby McGonigle <bobby@nexthop.ai>
@bobby-nexthop
bobby-nexthop force-pushed the sff8024-lro-appsel-codes branch from f721d5f to c5c2848 Compare August 27, 2026 16:45
@mssonicbld

Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).

@bgallagher-nexthop bgallagher-nexthop left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nh-grecs Bot pushed a commit to nexthop-ai/sonic-platform-common that referenced this pull request Aug 28, 2026
rebuild-source: sonic-net#749 @ nexthop-ai/sonic-platform-common c5c2848 [case: upstream:open]
nh-grecs Bot pushed a commit to nexthop-ai/sonic-platform-common that referenced this pull request Aug 29, 2026
rebuild-source: sonic-net#749 @ nexthop-ai/sonic-platform-common c5c2848 [case: upstream:open]
nh-grecs Bot pushed a commit to nexthop-ai/sonic-platform-common that referenced this pull request Aug 29, 2026
rebuild-source: sonic-net#749 @ nexthop-ai/sonic-platform-common c5c2848 [case: upstream:open]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants