ci: run build, vet and tests on push and PRs#20
Merged
Conversation
Adds a CI workflow gating master and PRs on `go build`, `go vet` and `go test -race`. Uses go-version-file so the toolchain tracks the go.mod directive. Lint/gofmt gating is intentionally omitted for now to avoid failing on pre-existing formatting in some test files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a
CIworkflow that runs on every push tomasterand every pull request:go build ./...go vet ./...go test -race ./...go-version-file: go.modso the toolchain follows thegodirective automatically (handy alongside #17, which bumps it to 1.26).Scope note
Lint /
gofmtgating is intentionally left out for now — a couple of pre-existing test files (executor_test.go,handler_test.go) aren't gofmt-clean, so a formatting gate would fail red on master. Easy to add once those are formatted.Closes the gap where #17 and #18 could merge with no automated verification.