Refactoring (related to PR #2474 code-review)#2562
Open
goran-w wants to merge 1 commit into
Open
Conversation
goran-w
commented
Jul 24, 2026
goran-w
commented
Contributor
- Pass unmodified 'lineBytes' into ParseChunkBodyLine(), and clarify the use of its indicator-stripped subset by adding new variable 'rawContent' (matching the existing variable 'content').
- Move assignment of '_isInChunk = true' from (callee) ParseChunkStartLine() into (caller) ParseLine(), which makes it easier to see how the variable is used (since it is also checked and set to false in this outer scope).
- Clarify the phrasing of two related comments.
* Pass unmodified 'lineBytes' into ParseChunkBodyLine(), and clarify the use of its indicator-stripped subset by adding new variable 'rawContent' (matching the existing variable 'content'). * Move assignment of '_isInChunk = true' from (callee) ParseChunkStartLine() into (caller) ParseLine(), which makes it easier to see how the variable is used (since it is also checked and set to false in this outer scope). * Clarify the phrasing of two related comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.