Widen the codex filing recognizer's create terminator to accept newline - #731
Merged
clkao merged 1 commit intoAug 18, 2026
Merged
Conversation
commandFilesViaNew's direct-invocation terminator (shared_filing_test.go:53) and codexFilingCreateCount's create counter (:183) both stopped at [ \t';|&] or end-of-string, so a compliant create followed by a verification command on the next line (run 32105482382) graded as "0 atomic creates" — punishing an FO that verified its own filing. Add the exact run-32105482382 public bytes (codex-exec.jsonl line 14, artifact 9313785785) as a fixture constant plus two seven-rung-matrix rows: the real create+newline+verify transaction now passes, and the same bytes with the create verb corrupted stay red, pinning both terminator classes with one positive and one negative row.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A compliant agent that filed an entity with a newline-terminated command was graded as if it never filed at all. This stops the codex-live
filingjourney from reddening correct behavior.What changed
codexFilingCreateCount's create terminator to accept a newline.commandFilesViaNew's direct-invocation terminator to accept a newline.Evidence
go test ./internal/ensigncycle/... -race -count=1: 44/44 filing subtests passed, including 22 red-expectation rows.ca9