Cite the delegated conn on FO gate resolutions; pin the grader to the FO actor - #733
Merged
Conversation
… FO actor
Under a granted conn, the durable Resolution now attributes agent:first-officer
and carries a required conn: {quote, source} citation instead of leaving the
actor to the FO's own self-description. gate record refuses an FO chat decision
without --conn-quote/--conn-source, refuses those flags on a person:captain
decision or with --round/--briefing, and gates.Read refuses a conn: block on a
non-FO resolution -- each exit 2 (CLI) or a read error, byte-clean.
recorded-gate-lifecycle's grader no longer derives the expected actor from the
FO's own close command (finding 9's circularity); it pins agent:first-officer,
requires the citation's quote to carry the granted phrase and appear verbatim
in the granting runbook, and reds a person:* actor under the distinct code
conn-approval-misattributed. auto-continue gains the boundary negative: an
FO-attributed, conn-cited resolution on its no-conn runbook still reds
human-gate-bypassed -- a citation is attribution, never authorization.
docs/specs/gate-resolution-frontmatter-contract.md, command-reference.md, and
gates-and-decisions.md still need the matching prose update; they are out of
this entity's file ownership in the PR stack (command-reference.md is owned by
the sibling merge-guard-requires-preceding-report entity) and are called out
in the stage report for FO routing.
…note Cycle 2, granted scope (file-ownership note from cycle 1 was in error): docs/specs/gate-resolution-frontmatter-contract.md's command-surface grammar and delegated-resolution paragraph, the docs/site command-reference.md gate record row, and the gates-and-decisions.md concept paragraph now describe the required --conn-quote/--conn-source citation exactly as the approved ideation specified. shared_live_runner_test.go's finding-9 AUDIT note is retired -- the grader it described (recorded-gate-lifecycle's actor-following expected-actor derivation) no longer exists as of cycle 1's fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A First Officer could sign a gate approval as the captain for a decision no captain made, and the grader accepted it because it derived the expected approver from the First Officer's own command. This makes the two record shapes impossible to confuse.
What changed
conncitation mapping to gate resolutions.Evidence
go test ./... -race: green except one pre-existing machine-local failure reproduced identically onmain.j7j