SRCH-694 return parser error for oversized days#84
Merged
Conversation
| assert_equal 0, expressions.last[:block_group] | ||
| end | ||
|
|
||
| test 'oversized days() in Bt range returns parser error instead of raising' do |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes a parser crash when days() or weekdays() exceed the maximum allowed offset inside a multi-value expression (e.g. a Bt range).
Changes in ParserTools:
Also adds a parser integration test and bumps the gem to v1.3.6.
Why
For filters like:
the second days() fails validation, tokenize_function returns nil, and tokenize_multiple then dereferences nil → NoMethodError → 500 in the API.
Expected behavior is a parser error (e.g. Function call 'days' max offset 365000 days), not an unhandled exception. This change ensures resolver validation failures are surfaced to the caller the same way as other parse errors.
AI
Cursor 3.8.11, Agent, Auto