Skip to content

refactor: remove intermediate-file cleanup option #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lm-sousa wants to merge 1 commit into from
Open

refactor: remove intermediate-file cleanup option #239

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions ClangAstParser/src/pt/up/fe/specs/clang/dumper/ClangAstDumper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,16 +62,6 @@ public static boolean usePlugin() {
private final static String CLANG_DUMP_FILENAME = "clangDump.txt";
private final static String STDERR_DUMP_FILENAME = "stderr.txt";

private static final List<String> CLANG_AST_DUMPER_TEMP_FILES = List.of("includes.txt", CLANG_DUMP_FILENAME,
// "clavaDump.txt", "nodetypes.txt", "types.txt", "is_temporary.txt", "template_args.txt",
"clavaDump.txt", "nodetypes.txt", "types.txt", "is_temporary.txt",
"omp.txt", "invalid_source.txt", "enum_integer_type.txt", "consumer_order.txt",
"types_with_templates.txt");

public static List<String> getTempFiles() {
return CLANG_AST_DUMPER_TEMP_FILES;
}

/**
* TODO: Not implemented yet
* <p>
Expand Down
8 changes: 0 additions & 8 deletions ClavaWeaver/src/pt/up/fe/specs/clava/weaver/CxxWeaver.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
import pt.up.fe.specs.clang.SupportedPlatform;
import pt.up.fe.specs.clang.codeparser.CodeParser;
import pt.up.fe.specs.clang.codeparser.ParallelCodeParser;
import pt.up.fe.specs.clang.dumper.ClangAstDumper;
import pt.up.fe.specs.clava.ClavaLog;
import pt.up.fe.specs.clava.ClavaNode;
import pt.up.fe.specs.clava.ClavaOptions;
Expand Down Expand Up @@ -797,13 +796,6 @@ protected boolean close() {
SpecsIo.deleteFolder(new File(TEMP_SRC_FOLDER));

if (this.dataStore != null) {
// Delete intermediary files
if (this.dataStore.get(CxxWeaverOption.CLEAN_INTERMEDIATE_FILES)) {
for (String tempFile : ClangAstDumper.getTempFiles()) {
new File(tempFile).delete();
}
}

// Re-enable output
if (this.dataStore.get(CxxWeaverOption.DISABLE_CLAVA_INFO)) {
SpecsLogs.getSpecsLogger().setLevelAll(null);
Expand Down
5 changes: 1 addition & 4 deletions ClavaWeaver/src/pt/up/fe/specs/clava/weaver/options/CxxWeaverOption.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,6 @@ public interface CxxWeaverOption {
DataKey<Boolean> CHECK_SYNTAX = KeyFactory.bool("Check C/CXX Syntax")
.setLabel("Check C/C++ syntax (performs additional parsing step)");

DataKey<Boolean> CLEAN_INTERMEDIATE_FILES = KeyFactory.bool("Clean intermediate files")
.setDefault(() -> true);

DataKey<FileList> HEADER_INCLUDES = LaraIKeyFactory.folderList("header includes")
.setLabel("Normal Includes")
.setDefault(FileList::newInstance);
Expand Down Expand Up @@ -85,7 +82,7 @@ public interface CxxWeaverOption {

StoreDefinition STORE_DEFINITION = new StoreDefinitionBuilder("C/C++ Weaver")
.addKeys(ClavaOptions.STORE_DEFINITION.getKeys())
.addKeys(WOVEN_CODE_FOLDERNAME, DISABLE_CLAVA_INFO, CHECK_SYNTAX, CLEAN_INTERMEDIATE_FILES,
.addKeys(WOVEN_CODE_FOLDERNAME, DISABLE_CLAVA_INFO, CHECK_SYNTAX,
HEADER_INCLUDES,
// SKIP_HEADER_INCLUDES_PARSING,
PARSE_INCLUDES,
Expand Down
2 changes: 0 additions & 2 deletions ClavaWeaver/src/pt/up/fe/specs/clava/weaver/options/CxxWeaverOptions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,6 @@ public class CxxWeaverOptions {

addBooleanOption(CxxWeaverOption.CHECK_SYNTAX, "cs", "check-syntax", "Checks syntax of woven code");

addBooleanOption(CxxWeaverOption.CLEAN_INTERMEDIATE_FILES, "cl", "clean", "Clean intermediate files");

addBooleanOption(CxxWeaverOption.DISABLE_CODE_GENERATION, "ncg", "no-code-gen",
"Disables automatic code generation");

Expand Down
Loading