Skip to content

Ts6 - #246

Open
lm-sousa wants to merge 12 commits into
langSpecV3from
ts6
Open

Ts6#246
lm-sousa wants to merge 12 commits into
langSpecV3from
ts6

Conversation

@lm-sousa

Copy link
Copy Markdown
Member

No description provided.

Copilot AI lite review requested due to automatic review settings August 28, 2026 20:43

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a8c215e87b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread Clava-JS/package.json
"exports": {
"./api/*.test.ts": null,
"./api/*.config.ts": null,
"./api/*": "./api/*.ts",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Preserve the published .js API subpaths

For existing scripts that import paths such as @specs-feup/clava/api/clava/Clava.js, this wildcard captures clava/Clava.js and resolves it to the nonexistent ./api/clava/Clava.js.ts. This affects dozens of checked-in ClavaWeaver resource scripts and is reproducible with Node 24 before the target module is loaded; add an explicit ./api/*.js-to-./api/*.ts mapping (and the equivalent for code) or continue publishing compiled .js files.

Useful? React with 👍 / 👎.

# Only on ubuntu-latest
- name: Publish JS
if: matrix.os == 'ubuntu-latest' && matrix.node-version == '22.x'
if: github.event_name == 'push' && github.ref == 'refs/heads/staging' && matrix.os == 'ubuntu-latest' && matrix.node-version == '25.x'

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Restore stable publishing for master pushes

For a release push to refs/heads/master, this condition now skips the only repository workflow containing npm publish; the remaining command publishes staging prereleases under the staging tag only. Consequently, even a master commit with a deliberately bumped package version can no longer publish the stable latest package as the previous branch explicitly did.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants