Skip to content

Ts6 - #107

Open
lm-sousa wants to merge 14 commits into
langSpecV3from
ts6
Open

Ts6#107
lm-sousa wants to merge 14 commits into
langSpecV3from
ts6

Conversation

@lm-sousa

Copy link
Copy Markdown
Member

No description provided.

…ly erasable syntax is allowed

- Removed a couple of deprecated files.
- Transformed enums into "const" declarations.
- Modified the tsconfig.json files
- Updated to TS 6 while I was at it.
Since we do not transpile TS anymore, the sources have been moved to their old destination folders.
The problem stems from the requirement of Node.js of "rewriteRelativeImportExtensions" to be "true".
This causes any import that refers to the package name ("@specs-feup/lara/...") to throw a compilation error when compiling Lara-JS.
However, if we rewrite them to use relative imports, the Jest config in the downstream weavers will error out.
Thus, we added directives for the Typescript compiler to ignore the errors in these particular lines.
The ignore directives were of the appropriate scope as to avoid compilation errors in Lara-JS and in the downstream weavers' compilations.
Copilot AI lite review requested due to automatic review settings August 28, 2026 20:54

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 691df915ed

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread Lara-JS/package.json
"exports": {
"./api/*.test.ts": null,
"./api/*.config.ts": null,
"./api/*": "./api/*.ts",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Preserve existing .js subpath imports

When an existing consumer imports a previously published path such as @specs-feup/lara/api/lara/util/Accumulator.js, this pattern captures lara/util/Accumulator.js and resolves it to api/lara/util/Accumulator.js.ts, which does not exist. Under Node 24.15 this produces ERR_MODULE_NOT_FOUND; the repository's legacy scripts still use these .js specifiers (for example LARAI/resources/larai/test/api/AccumulatorTest.js), and Weaver.executeScript() loads such scripts with native import(), outside Jest's mapper. Add explicit .js compatibility patterns mapping to the corresponding .ts files before publishing the native-TypeScript package.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants