Conversation
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9cfc957e75
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| fs.writeSync(outputFile, `export const ${e.name} = {\n`); | ||
| e.entries.forEach((entry) => { | ||
| fs.writeSync(outputFile, ` ${entry}: "${entry.toLowerCase()}",\n`); | ||
| fs.writeSync(outputFile, ` ${entry}: "${entry}",\n`); |
There was a problem hiding this comment.
When a v3 specification uses the supported value("STATIC", "static") form, JsonSerializer.writeEnumDef() emits both value and display, but convertEnum() discards display, so this line now generates STATIC: "STATIC". The Java bridge returns getDisplay() for enum attributes (WeaverGen2/src/org/lara/weavergen2/emit/JoinPointTypeRenderer.java:143-150), meaning the generated TypeScript type permits only "STATIC" while the runtime yields "static", breaking comparisons and the declared return type. Carry the display string through conversion and use it for the generated value, falling back to the programmatic value when absent.
Useful? React with 👍 / 👎.
No description provided.