Update OpenTelemetry dependencies and use experimental semantic convention constants#3567
Open
ChihweiLHBird wants to merge 1 commit into
Open
Update OpenTelemetry dependencies and use experimental semantic convention constants#3567ChihweiLHBird wants to merge 1 commit into
ChihweiLHBird wants to merge 1 commit into
Conversation
Signed-off-by: Zhiwei Liang <zhiwei.liang@zliang.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
opentelemetry_sdk::metrics::data::ResourceMetrics.opentelemetry-semantic-conventions.Details
Continue previous work of compile-time references for the emitted attribute keys and makes future semantic convention migrations easier to identify during dependency updates.
The workspace enables
semconv_experimentalbecause Spin was already emitting experimental semantic convention attributes as string literals before this change, including attributes such ashttp.response.body.sizeanddb.namespace. Enabling the feature does not introduce new telemetry concepts by itself; it lets the existing experimental attribute names come from the same upstream conventions crate as the stable attributes.Breaking Changes / Compatibility
This changes some emitted OpenTelemetry span attribute names as part of replacing deprecated semantic convention attributes with their newer equivalents. Consumers that collects these attributes should update their telemetry rules accordingly.
Notable replacements include:
db.system->db.system.namedb.address->server.address