Conversation
Update the dialect for newer SQLAlchemy and Google Datastore client behavior without hiding warnings globally. Add import_dbapi while keeping dbapi as a compatibility wrapper, and set supports_statement_cache to False so SQLAlchemy does not warn about an unsupported statement cache contract. Use google.cloud.datastore.query.PropertyFilter in get_columns to avoid the Datastore positional add_filter deprecation path. Adjust integration tests that only need to locate inserted emulator entities so they no longer call the deprecated add_filter form. Improve the unknown BigQuery type unit test to assert the expected SQLAlchemy SAWarning and NullType fallback. UNKNOWN_TYPE_XYZ is intentionally unsupported in the test fixture, so the warning is part of the expected behavior rather than something to suppress. Do not raise requires-python to 3.11 in this commit. The current google-cloud-datastore 2.26.0 metadata still supports Python >=3.10; moving this project to Python >=3.11 should be handled as a separate support-policy change because Python 3.10 remains inside the declared project range even though Google now warns about its 2026-10-04 EOL.
splasky
marked this pull request as ready for review
August 11, 2026 17:23
splasky
force-pushed
the
warning
branch
2 times, most recently
from
August 11, 2026 17:33
b312b5c to
9383516
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Python version decision
This PR does not change requires-python. Latest google-cloud-datastore 2.26.0 still declares Python >=3.10 support, so raising this project to Python >=3.11 is a separate support-policy change. I will handle that work on a dedicated branch.
Validation
The remaining warnings are Google client library Python 3.10 EOL notices, not the UNKNOWN_TYPE_XYZ warning covered by this PR.