Segment, parser and storage commons#623
Merged
gthea merged 5 commits intomod_baselinefrom Apr 17, 2026
Merged
Conversation
AI-Session-Id: 095253e8-7e1c-4578-9779-bf96395021cf AI-Tool: claude-code AI-Model: unknown
AI-Session-Id: 095253e8-7e1c-4578-9779-bf96395021cf AI-Tool: claude-code AI-Model: unknown
Collapses an unnecessary module layer by moving all RuleBasedSegment concerns (DTO, domain model, parser, cache interfaces, in-memory impl) directly into segment-commons, which was the sole consumer. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> AI-Session-Id: a0fded26-6434-4263-90b0-a163e1cf0faf AI-Tool: claude-code AI-Model: unknown
EmilianoSanchez
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added parsing and segment commons modules.