Add encodeImmutable for generated columns - #5
Open
kryptus36 wants to merge 1 commit into
Open
Conversation
Table-backed encode stays STABLE because it reads the blocklist. Reject negative and NULL numbers instead of hanging in toId. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Table-backed encode stays STABLE because it reads the blocklist. Reject negative and NULL numbers instead of hanging in toId.
Supersedes #3
Fixes #4
Looking for feedback on the idea of encodeImmutable being added on for generated columns, but leaving encode as stable and matching sqids implementation.
Added tests for immutable, negative number blocking.
If feedback is positive, I'll merge.