chore: upgrade to Node 24 and move pnpm overrides to pnpm-workspace.yaml - #48
Merged
Merged
Conversation
Consolidate all pnpm config into pnpm-workspace.yaml (overrides + onlyBuiltDependencies join the existing minimumReleaseAge settings) and remove the pnpm key from package.json, so pnpm 10 reads settings from a single source. Bump every Node reference to 24: .nvmrc, root engines (>=24), the tsup build target, @types/node (24.13.3), and the CI/release workflow comments (they already resolve Node via .nvmrc). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Two mechanical infra changes:
1. Migrate pnpm overrides →
pnpm-workspace.yaml. Thepnpmblock (overrides+onlyBuiltDependencies) moves out ofpackage.jsonintopnpm-workspace.yamlas top-level keys, joining theminimumReleaseAge/minimumReleaseAgeExcludesettings that already lived there. Thepnpmkey is deleted frompackage.json, so pnpm 10 reads all settings from a single source (no "settings in both files" ambiguity). Resolution is unchanged — the lockfile still resolves the same patched versions (tar 7.5.22, axios 1.19.0, esbuild 0.28.1, postcss 8.5.25, body-parser 2.3.0, form-data 4.0.6, hono 4.12.32, fast-uri 3.1.4).2. Node 24 everywhere.
.nvmrc:22.22.0→24(both workflows resolve Node vianode-version-file: .nvmrc)engines.node:>=22.22.0→>=24tsupbuild target:node22→node24@types/node:^22.10.0→^24.13.3Verification
pnpm install --no-frozen-lockfile— clean, no dual-settings warningpnpm audit— No known vulnerabilities foundpnpm typecheck(tsc) — pass (clean under@types/node24)pnpm build(tsup) — pass, target node24Note: no
.node-versionfile exists in this repo (only.nvmrc), and there are no Dockerfiles or per-packageengines, so those playbook steps were N/A.🤖 Generated with Claude Code