fix: retain scroll position in details panel tables during periodic updates - #346
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the issue where scrolling down tables in the torrent details panel (Peers, Trackers, Files) would jump back to the top whenever the 1-second polling update occurred.
Cause
Previously,
update_peers(),update_trackers(), andupdate_files()calledtable.clear()on every tick, which emptied all rows and reset Textual's viewportscroll_yoffset to 0.Fix
peer.ip,tracker.url,file.index).table.update_cell(...)only when cell contents change, leaving the table's DOM and scroll offset untouched.table.add_row(..., key=key).table.remove_row(...).clear_tables()toDetailsPanelcalled when selecting a different torrent to ensure data refreshes cleanly between torrents.tests/test_widgets_details_panel.pyverifying scroll position retention and in-place row updates.