test: cover pre-1.0 gaps and drop dead skip scaffolding#143
Merged
Conversation
Signed-off-by: Joshua Temple <joshua.temple@stablekernel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this change does
Targeted pre-1.0 test improvements (additive), from the coverage survey:
source/memsourcebatch coverage 76.6% to 94.9% (clears the last sub-gate package): in-package tests for the batch harness lane (RunBatch/NextBatch/SettleBatch, theBatchedcapability path, drain).state/fire.go guardsPasssafety branch (~33% to 88.9%): asserts a panicking guard on an eventlessAlwaystransition does not silently enable it.Exampletests that double as godoc:Builder.Quench(the finalize seam), JSON-rehydrate-then-Provide-then-run, and anActorSystemlifecycle (Spawn/deliver/Stop, previously ~0% covered).ToJSON(WithoutSrcPos)is byte-idempotent across a re-decode (the propertyevolution.DiffMachinesrelies on).t.Skipred-phase scaffolding blocks (gated on asafeBuildcondition that always passes now) plus the unused helper.Checklist
statetests + vet green;source/memsource≥80% and race-clean; deterministic Examples with real// Output: