One best-effort reconcile policy for automatic setup triggers - #176
Merged
Conversation
sail up and the boot sweep each carried an identical try-ensureInstalled- warn wrapper. The single-container policy now lives once, in ContainerSetupSweep.reconcile; the sweep loops it and sail up calls it. Callers needing the outcome or their own error handling (dispatch, provisioner, renamer, reconfigure) keep calling ensureInstalled directly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #175 (review feedback):
sail upand the boot sweep each carried an identical try-ensureInstalled-warn wrapper — two homes for one policy. The single-container best-effort reconcile now lives once inContainerSetupSweep.reconcile; the sweep loops it,sail upcalls it. Explicit-outcome callers (dispatch, provisioner, renamer,reconfigure) keep usingContainerSailSetup.ensureInstalleddirectly, which stays the one idempotent seam.No behavior change; tests moved to the consolidated seam.
mvn clean testgreen.