Avoid catastrophic bactracking in t-017 - #1004
Merged
Merged
Conversation
By making the (\w+\s*)+ sub-pattern possessive: There is no reason for the regex engine to backtrack in this pattern if it fails to match, as neither \w nor \s contains any of the punctuation that this lint is concerned with. Add a basic test for this lint to prevent regressions here. Fixes standardebooks#1003
apasel422
marked this pull request as ready for review
August 10, 2026 23:29
Member
|
Great work, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By making the (\w+\s*)+ sub-pattern possessive: There is no reason for the regex engine to backtrack in this pattern if it fails to match, as neither \w nor \s contains any of the subsequent punctuation that this lint is concerned with.
Add a basic test for this lint to prevent regressions here: Without the associated fix, the test never terminates.
Fixes #1003