Skip to content

modernize-spelling: Bagdad -> Baghdad - #1008

Merged
acabal merged 1 commit into
standardebooks:masterfrom
HendrikBK:master
Aug 18, 2026
Merged

modernize-spelling: Bagdad -> Baghdad#1008
acabal merged 1 commit into
standardebooks:masterfrom
HendrikBK:master

Conversation

@HendrikBK

Copy link
Copy Markdown
Contributor

This is my first time making any updates to the toolset, so please tell me if I got the idea correctly.

From what I understand, the words file has words that need to lose the hyphen, correct? Or am I reading the code incorrectly?

I also noticed that some words have different lines for their capitalized and non-capitalized versions; is there a particular reason for that? I'm trying to understand.

@acabal

acabal commented Aug 18, 2026

Copy link
Copy Markdown
Member

From what I understand, the words file has words that need to lose the hyphen, correct? Or am I reading the code incorrectly?

Correct

I also noticed that some words have different lines for their capitalized and non-capitalized versions; is there a particular reason for that? I'm trying to understand.

It's not possible for regex to replace a capital with a lowercase so for these cases we need two regexes.

This looks good but \b is not necessary on either end. This word will never occur within another word, and we also want to catch cases like Bagdadi.

@acabal

acabal commented Aug 18, 2026

Copy link
Copy Markdown
Member

Thanks!

@acabal
acabal merged commit ac08f0c into standardebooks:master Aug 18, 2026
@HendrikBK

Copy link
Copy Markdown
Contributor Author

I rebased the change, it should work now.

It's not possible for regex to replace a capital with a lowercase so for these cases we need two regexes.

Of course, Only now I realize that the words that use a capture group don't change the first letter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants