[adminer] release 1.0.2 — fix ingress annotations (#125) & pod automountServiceAccountToken (#127), st-common OCI#128
Merged
firmansyahn merged 2 commits intoJun 19, 2026
Conversation
…ntServiceAccountToken (#127), st-common OCI - Ingress.yaml: use st-common.tplvalues.render and drop the stray nested annotations key so ingress/common annotations render (fixes #125). - Deployment.yaml: render top-level automountServiceAccountToken on the pod spec, covering serviceAccount.create=false (fixes #127). - Chart.yaml: move st-common dep to oci://ghcr.io/startechnica/charts (0.1.21); regenerate and commit Chart.lock; un-ignore Chart.lock in chart .gitignore. - Version 1.0.1 -> 1.0.2; CHANGELOG, README shield, artifacthub.io/changes.
ct lint (yamllint) flagged trailing whitespace at values.yaml:492 in the resourcesPreset @param comment. Pre-existing; surfaced now because the 1.0.2 version bump puts adminer in ct's changed-charts set.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bug-fix release for the
adminerchart (1.0.1 → 1.0.2). Template-only behavior changes — no values defaults orappVersionchange; existing installs upgrade in place with no action.ingress.annotationsorcommonAnnotationswas set (no template "common.tplvalues.render" associated with template "gotpl"). The block called the pre-migration helper name and emitted a second nestedannotations:key insidemetadata.annotations. Now usesst-common.tplvalues.renderand renders the merged map directly undermetadata.annotations.automountServiceAccountTokenvalue was never rendered intospec.template.spec.automountServiceAccountToken, so it had no effect whenserviceAccount.create: false(existing/defaultSA reuse). The pod spec now renders it.Both issues reported by @attilaolah.
Also in this release
st-commondependency moved from the GitHub Pages HTTP repo to the GHCR OCI registry (oci://ghcr.io/startechnica/charts, 0.1.20 → 0.1.21), aligning withfreeradius/netbox.Chart.lockregenerated and now committed (chart.gitignoreno longer ignores*.lock).Chart.yaml, README shield,artifacthub.io/changes, andCHANGELOG.md.Verification
helm lint charts/adminer→ 0 failed.helm templatewith each issue's reproduction values renders correctly:metadata.annotations.automountServiceAccountToken: falserenders withserviceAccount.create=false.helm dependency updatepulledst-common:0.1.21from GHCR and pinned the digest.Closes #125
Closes #127