[adminer] release 1.1.0 — add initContainers value (#129)#130
Merged
Conversation
Inject init containers into the Adminer pod via a new top-level `initContainers` value, rendered into the pod spec's `initContainers:` array (runs to completion before the main container). Useful for preparing shared volumes ahead of the main container — e.g. assembling a combined CA bundle into an emptyDir for an oauth2-proxy sidecar. Pairs with extraVolumes/extraVolumeMounts; complements the existing sidecars value rather than replacing it. - templates/Deployment.yaml: render initContainers before containers - values.yaml: initContainers param (ref link + CA-bundle example) - values.schema.json: initContainers array type - README.md: params-table row - Chart.yaml: 1.0.2 -> 1.1.0 (additive), refresh artifacthub.io/changes - remove unused values-test.yaml fixture (not wired into ct/unittest) Reported by @attilaolah.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a top-level
initContainersvalue to the adminer chart so users can inject init containers into the Adminer pod without post-render hacks.Rendered into the pod spec's
initContainers:array (runs to completion before the main container starts) — distinct from the existingsidecarsvalue (long-running co-containers spliced intocontainers:).Why
Closes #129 (reported by @attilaolah). Motivating use case: Adminer behind an oauth2-proxy sidecar that needs a combined CA bundle (public trust anchors + a self-signed private CA for a valkey/redis session cache). An init container assembles the bundle into an
emptyDirbefore the main containers start. Pairs withextraVolumes/extraVolumeMounts.Changes
templates/Deployment.yaml— renderinitContainersbeforecontainersvalues.yaml—initContainersparam (k8s ref link + CA-bundle example)values.schema.json—initContainersarray typeREADME.md— params-table rowChart.yaml—1.0.2→1.1.0(additive, minor); refreshartifacthub.io/changesvalues-test.yamlfixture (not wired intoct/helm-unittest)Verification
helm templatewithinitContainersset renders the array beforecontainers:(exit 0). Additive only — no breaking changes; installs from 1.0.x upgrade in place with no action.