docs: fix default value documentation - #14325
Merged
Merged
Conversation
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
kgryte
approved these changes
Aug 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up fixes for commits merged to
developbetween 2026-08-15T05:33:22-07:00 (ee85255c) and 2026-08-16T02:40:52-07:00 (066149c2).This pull request:
blas/ext/base/ndarray/gdiff: Fix@returnsannotation ingdiffmain.js (line 48) to matchndarrayfamily:1004397tagged it{Object}whilesdiff/cdiff/zdiff/ddiffall use{ndarray}; changed to@returns {ndarray} output ndarrayfor consistency inlib/node_modules/@stdlib/blas/ext/base/ndarray/gdiff/lib/main.js.stats/base/ndarray/dnanmin: FixNaN→0.0/0.0inlib/node_modules/@stdlib/stats/base/ndarray/dnanmin/README.md(L144);NaNisn't a valid C identifier, so the example doesn't compile. Introduced in 0222395;examples/c/example.cand the snanmin README already use the correct form.blas/ext/copy-within: Fixes stale documentation of the default source end index inblas/ext/copy-within:lib/main.jsdefaultsendtoN(elements alongoptions.dim), butREADME.md(L57) anddocs/repl.txt(L34–35), introduced in 8dc4cd2, both stateN + 1, which is out-of-bounds and only harmless because of clamping. Corrects both docs toN.Related Issues
No.
Questions
No.
Other
Validation. All 36 commits merged to
developin the review window were checked for style-guide compliance (againstdocs/style-guidesand established sibling packages) and scanned for bugs by multiple independent review passes. Checked and found clean: wrapper glue and argument order in the newblas/ext/base/ndarraydiff/cunone/last-index-of-truthy families, JS/C coefficient and branch parity formath/base/special/erfinvf/erfcinvf(all 178 rational coefficients round-trip to identical float32 values; Julia fixtures pass within declared ULP tolerances),blas/ext/logspaceargument normalization against itslinspacetemplate,blas/ext/copy-withinsemantics againstArray.prototype.copyWithin,dnanmin/snanminaddon signatures and dtypes, theno-empty-lines-between-requireslint-rule fix, and the ULP test migrations. Deliberately excluded: anything requiring interpretation or judgment (e.g. mixedNaNvs0.0/0.0precedent in older READMEs, named-constant vs inlined-literal styles), and anything that would require changes outside the window's diff.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored by Claude Code as part of a scheduled automated review of the last 24 hours of commits merged to
develop; each fix was independently re-verified against the repository before being applied.Generated by Claude Code