test: migrate stats/base/dists/discrete-uniform/median to ULP-based assertions - #14339
Merged
Conversation
… assertions Ref: #11352 Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019hrk86NWAm29g4zkctUY4b --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: skipped - task: lint_markdown_pkg_readmes status: na - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves a part of #11352.
Description
This pull request:
stats/base/dists/discrete-uniform/medianfrom relative tolerance assertions to ULP-based assertions.Specifically, in
test/test.jsandtest/test.native.js, theif ( y === expected[i] ) { ... } else { delta/tol ... }branch is replaced byalong with the corresponding require of
@stdlib/assert/is-almost-same-valueand the removal of the now unused@stdlib/math/base/special/absand@stdlib/constants/float64/epsrequires.ULP bound:
0in bothtest/test.jsandtest/test.native.js.The bound was determined empirically by computing, for every entry in the Julia fixture set (1000 cases), the minimum ULP difference required for the assertion to hold. The maximum required over the full fixture set is
0, i.e., every returned value is bit-identical to the expected value, so0is the minimum admissible bound. The test suite was run twice at the final bound to confirm determinism (1008 assertions passing on each run).This result is consistent with the implementations: the JS implementation returns
( a/2 ) + ( b/2 )and the C implementation returns( a + b ) / 2.0, both of which are exact for integer-valuedaandbin the tested range, and both of which agree bit-for-bit with the fixture values. Note that the native tests are skipped when the native add-on has not been built, so the native bound was additionally checked by evaluating the C expression over the same fixture set.Only the two test files are modified; no source, fixture, or documentation files are touched.
Related Issues
This pull request has the following related issues:
math/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352Questions
No.
Other
The conversion mirrors the idiom used in the previously merged sibling package
stats/base/dists/discrete-uniform/stdev(#14337).Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored by Claude Code running as an unattended scheduled task: it selected the package, studied previously merged ULP migrations for the idiom, applied the test changes, and determined the minimum ULP bound empirically over the fixture set.
@stdlib-js/reviewers
Generated by Claude Code