test: migrate math/base/special/bessely0 to ULP-based assertions - #14351
Closed
kgryte wants to merge 2 commits into
Closed
test: migrate math/base/special/bessely0 to ULP-based assertions#14351kgryte wants to merge 2 commits into
math/base/special/bessely0 to ULP-based assertions#14351kgryte wants to merge 2 commits into
Conversation
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
Signed-off-by: Athan <kgryte@gmail.com>
Contributor
|
Thank you for working on this pull request. However, we cannot accept your contribution as the issue this pull request seeks to resolve has already been addressed in a different pull request or commit. Thank you again for your interest in stdlib, and we look forward to reviewing your future contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves a part of #11352.
Description
This pull request:
math/base/special/bessely0from relative tolerance testing to ULP difference testing, per [RFC]: Migratemath/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352.delta/tolcomputation and they === expectedspecial case intest/test.jsandtest/test.native.jswith a singlet.strictEqual( isAlmostSameValue( y, expected[ i ], N ), true, 'returns expected value' );assertion.@stdlib/math/base/special/absrequire and adds@stdlib/assert/is-almost-same-value. The@stdlib/constants/float64/epsrequire is retained, asEPSis still used when generating negative inputs.ULP bounds (
test/test.js):very_large_positive680.0 * EPS * abs( expected )1127large_positive2400.0 * EPS * abs( expected )3716medium_positive850.0 * EPS * abs( expected )1626small_positive1000.0 * EPS * abs( expected )1510smaller4.5 * EPS * abs( expected )7tiny_positive10.0 * EPS * abs( expected )2subnormal5000.0 * EPS * abs( expected )8678huge_positive4500.0 * EPS * abs( expected )4053positive_gamut16.0 * EPS * abs( expected )25These are the measured minima. Starting from a high bound and tightening, each value above is the smallest integer for which the corresponding fixture set passes in full: decrementing every bound by one fails 2448 of 41653 assertions (exactly one point per set, except
tiny_positive, where a bound of1fails 2440 points).test/test.native.jsuses the same bounds, with two exceptions. The two loops which previously carried a larger tolerance than their JavaScript counterparts (medium_positive:885.0 * EPSvs.850.0 * EPS;positive_gamut:130.0 * EPSvs.16.0 * EPS) retain their existingNOTEand keep the same proportional headroom over the measured minimum (1626→1693and25→203), since that headroom exists to absorb platform-dependent divergence between the JavaScript and C results (see the discussion referenced in the note). This mirrors the already-migratedmath/base/special/besselj0, whose native tests likewise keep a slightly larger bound for the loops carrying that note.Only the two test files are changed; no source, documentation, or
package.jsonchanges are included.Related Issues
This pull request has the following related issues:
math/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352Questions
The
subnormal(8678),huge_positive(4053), andlarge_positive(3716) bounds are large in absolute terms, but each is strictly tighter than the relative tolerance it replaces, and in each of those sets a single fixture point dominates (the next largest difference is 73, 945, and 232 ULP, respectively). Happy to round these to more convenient values if reviewers prefer some headroom over the measured minimum.Other
Verification performed locally:
test/test.js— 41653 passing, 0 failing. Run twice at the final bounds with identical results, so the bounds are not sensitive to FMA/arch variation on this machine.test/test.native.jsreports its assertions as skipped. To validate the native bounds,src/main.cwas compiled standalone (gcc, at both-O3and-O0) together with its resolved C dependencies and evaluated over the same fixture sets: the C results were bit-identical to the JavaScript results for all 40647 fixture points at both optimization levels, so the bounds above hold for the native implementation on this platform as well.eslint --config etc/eslint/.eslintrc.tests.jsover both files is clean.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored by Claude Code running as an unattended scheduled task. The test migration and the ULP bound search (start high, tighten to the minimum that still passes, then re-run to confirm determinism) were performed by the agent, following the idiom established in already-migrated packages in
math/base/special.@stdlib-js/reviewers
Generated by Claude Code