test: migrate math/base/special/csignumf to ULP-based assertions - #14354
Merged
Conversation
Replaces relative tolerance assertions with ULP difference assertions using `@stdlib/number/float32/base/assert/is-almost-same-value`. Ref: #11352 --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: skipped - task: lint_markdown_pkg_readmes status: na - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
kgryte
marked this pull request as ready for review
August 17, 2026 22:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves a part of #11352.
Description
This pull request:
math/base/special/csignumffrom relative tolerance testing to ULP difference testing.EPS-scaled tolerance comparisons intest/test.jsandtest/test.native.jswithisAlmostSameValueassertions from@stdlib/number/float32/base/assert/is-almost-same-value(the single-precision variant, ascsignumfreturns aComplex64).@stdlib/constants/float32/epsand@stdlib/math/base/special/absfrequires, along with the associateddeltaandtolvariables and the exact-versus-toleranceif...elsebranch.The final ULP bound is 1 ULP, applied to both the real and imaginary component assertions in
test/test.jsandtest/test.native.js.Related Issues
This pull request has the following related issues:
math/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352Questions
No.
Other
Notes on how the bound was determined:
test/fixtures/julia/data.json) contain 2003 test cases, yielding 4006 component assertions.@stdlib/number/float32/base/ulp-difference) between the JavaScript implementation and the fixture values over the full fixture set gives a maximum of 1 ULP for both the real and imaginary components (376 of the 2003 cases differ by exactly 1 ULP; the remainder are exact). Hence,1is the minimum required ULP value, and the tests fail at0.src/main.cagainst its manifest dependency closure and running it over the same fixture inputs. It produces an identical error profile (maximum 1 ULP, the same 376 non-exact cases), which is expected given that the JavaScript and C implementations use the same algorithm (z / cabsf( z )). Accordingly, the same bound of1is used intest/test.native.js.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored by Claude Code, following the idiom established in previously merged conversions (e.g. #14080 for the double-precision
csignumcounterpart, #14327, and theatan2fconversion for the single-precision assertion variant). The ULP bound was measured empirically over the full fixture set rather than guessed, for both the JavaScript and C implementations.@stdlib-js/reviewers
Generated by Claude Code