Skip to content

feat: add C implementation for stats/base/ndarray/dnanminabs - #14356

Open
ujjwalv01 wants to merge 2 commits into
stdlib-js:developfrom
ujjwalv01:feat-stats-base-ndarray-dnanminabs-c
Open

feat: add C implementation for stats/base/ndarray/dnanminabs#14356
ujjwalv01 wants to merge 2 commits into
stdlib-js:developfrom
ujjwalv01:feat-stats-base-ndarray-dnanminabs-c

Conversation

@ujjwalv01

Copy link
Copy Markdown
Contributor

Resolves a part of #14034

Description

What is the purpose of this pull request?

This pull request:

  • adds a native C implementation for computing the minimum absolute value of a one-dimensional double-precision floating-point ndarray (dnanminabs), ignoring NaN values.
  • updates the test suite (test.js, test.main.js, test.native.js) and benchmarks to cover and utilize the new native C addon.

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

I consulted an AI assistant to help structure and generate the test files (test.main.js, test.native.js) and benchmark files required to test the native C addon. The core logic and implementation were authored manually by myself.


@stdlib-js/reviewers

@ujjwalv01
ujjwalv01 marked this pull request as ready for review August 17, 2026 18:30
@ujjwalv01
ujjwalv01 requested a review from a team August 17, 2026 18:30
@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. labels Aug 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs Review A pull request which needs code review. Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants