Skip to content

test: migrate math/base/special/factorial2f to ULP-based assertions #14364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
kgryte wants to merge 1 commit into
base: develop
Choose a base branch
from
+8 −26
Draft

test: migrate math/base/special/factorial2f to ULP-based assertions #14364

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 4 additions & 13 deletions lib/node_modules/@stdlib/math/base/special/factorial2f/test/test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,10 @@

var tape = require( 'tape' );
var isnanf = require( '@stdlib/math/base/assert/is-nanf' );
var absf = require( '@stdlib/math/base/special/absf' );
var isAlmostSameValue = require( '@stdlib/number/float32/base/assert/is-almost-same-value' );
var incrspace = require( '@stdlib/array/base/incrspace' );
var PINF = require( '@stdlib/constants/float32/pinf' );
var NINF = require( '@stdlib/constants/float32/ninf' );
var EPS = require( '@stdlib/constants/float32/eps' );
var factorial2f = require( './../lib' );


Expand Down Expand Up @@ -76,8 +75,6 @@ tape( 'if provided `NaN`, the function returns `NaN`', function test( t ) {

tape( 'the function evaluates the double factorial', function test( t ) {
var expected;
var delta;
var tol;
var x;
var v;
var i;
Expand All @@ -87,15 +84,9 @@ tape( 'the function evaluates the double factorial', function test( t ) {

for ( i = 0; i < x.length; i++ ) {
v = factorial2f( x[ i ] );
if ( v === expected[ i ] ) {
t.strictEqual( v, expected[ i ], 'returns expected value' );
} else {
delta = absf( v - expected[i] );

// NOTE: We use approximate equality because expected values from SciPy are computed using gamma function approximations instead of iterative single-precision computation.
tol = 2.4 * EPS * absf( expected[i] );
t.ok( delta <= tol, 'within tolerance. x: '+x[i]+'. v: '+v+'. e: '+expected[i]+'. Δ: '+delta+'. tol: '+tol+'.' );
}

// NOTE: We use approximate equality because expected values from SciPy are computed using gamma function approximations instead of iterative single-precision computation.
t.strictEqual( isAlmostSameValue( v, expected[ i ], 3 ), true, 'returns expected value' );
}
t.end();
});
Expand Down
17 changes: 4 additions & 13 deletions lib/node_modules/@stdlib/math/base/special/factorial2f/test/test.native.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,10 @@
var resolve = require( 'path' ).resolve;
var tape = require( 'tape' );
var isnanf = require( '@stdlib/math/base/assert/is-nanf' );
var absf = require( '@stdlib/math/base/special/absf' );
var isAlmostSameValue = require( '@stdlib/number/float32/base/assert/is-almost-same-value' );
var incrspace = require( '@stdlib/array/base/incrspace' );
var PINF = require( '@stdlib/constants/float32/pinf' );
var NINF = require( '@stdlib/constants/float32/ninf' );
var EPS = require( '@stdlib/constants/float32/eps' );
var tryRequire = require( '@stdlib/utils/try-require' );


Expand Down Expand Up @@ -85,8 +84,6 @@ tape( 'if provided `NaN`, the function returns `NaN`', opts, function test( t )

tape( 'the function evaluates the double factorial', opts, function test( t ) {
var expected;
var delta;
var tol;
var x;
var v;
var i;
Expand All @@ -96,15 +93,9 @@ tape( 'the function evaluates the double factorial', opts, function test( t ) {

for ( i = 0; i < x.length; i++ ) {
v = factorial2f( x[ i ] );
if ( v === expected[ i ] ) {
t.strictEqual( v, expected[ i ], 'returns expected value' );
} else {
delta = absf( v - expected[i] );

// NOTE: We use approximate equality because expected values from SciPy are computed using gamma function approximations instead of iterative single-precision computation.
tol = 2.4 * EPS * absf( expected[i] );
t.ok( delta <= tol, 'within tolerance. x: '+x[i]+'. v: '+v+'. e: '+expected[i]+'. Δ: '+delta+'. tol: '+tol+'.' );
}

// NOTE: We use approximate equality because expected values from SciPy are computed using gamma function approximations instead of iterative single-precision computation.
t.strictEqual( isAlmostSameValue( v, expected[ i ], 3 ), true, 'returns expected value' );
}
t.end();
});
Expand Down