Conversation
- REC button in the transport cluster (glowing red while armed, pulse animation) + R shortcut; guarded against typing targets - engine captures noteOn/noteOff pairs while playing: nearest-step start quantization, length from the release moment, velocity preserved; out-of-range pitches and non-finite positions are rejected - the whole take is ONE history transaction — an empty take commits nothing, stopping the transport disarms and commits automatically
- grab an effect's type name and drop it between rows; insertion point shows as a bright edge marker on the neighbours, no-op gaps stay clean - pointer-capture based (works while zoomed), single history transaction per move via the same engine.moveEffect path as the arrow buttons
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two features on top of #8, per-feature commits for easy rollback.
Note recording (9f53ade)
RshortcutFX chain drag & drop (60dfdc9)
moveEffectpath as the ▲▼ buttons → identical undo/serialize behaviorTest plan
npx tsc --noEmitclean; build clean