chore(infra): remove empty Task and clarify crashlytics draft status - #166
Merged
Merged
Conversation
The empty Task file at repo root (0 bytes, sha e69de29) had no references in the codebase and served no purpose. Removed to clean up repo structure. Co-authored-by: Steven Gates <gates.steven@gmail.com>
The Crashlytics autotriage Cloud Function (functions/index.js) and its package.json still carried 'DRAFT — pending sign-off' markers, but the authoritative PRD (docs/PRD-crashlytics-autotriage.md line 3) states: '✅ Shipped and running in production.' The operational runbook (docs/FIREBASE.md) confirms production status with token rotation guidance and troubleshooting for the live system. Changed: - functions/index.js: removed 'DRAFT — pending sign-off' from header comment - functions/package.json: removed 'DRAFT' from description field No behavior change to the Cloud Function logic. DRAFT removal reflects documented production status; this is a documentation sync, not a sign-off. Co-authored-by: Steven Gates <gates.steven@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Infra hygiene PR with two scoped cleanup tasks:
Deleted empty
Taskfile: The root-levelTaskfile (0 bytes, shae69de29) had no references in the codebase and served no purpose. Grepped the entire codebase to confirm no file references exist—all matches were code references (e.g.,com.google.android.gms.tasks.Task). Removed to clean up repo structure.Removed DRAFT status from Crashlytics autotriage: The Cloud Function (
functions/index.js) andfunctions/package.jsonstill carried "DRAFT — pending sign-off" markers, but the authoritative PRD (docs/PRD-crashlytics-autotriage.mdline 3) explicitly states: "✅ Shipped and running in production." The operational runbook (docs/FIREBASE.md) confirms production status with token rotation guidance and live system troubleshooting. This change syncs code comments to documented reality—no logic changes, no sign-off invention.Related Issue
N/A — cleanup only
Type of Change
How Has This Been Tested?
Taskfile was 0 bytes and tracked at repo rootTaskfile—only found code references, no file referencesChecklist
allWarningsAsErrorsis on)..\scripts\pre-pr-sweep.ps1→build/sweep-receipt.json): SKIPPED — this PR touches only non-compiled files (emptyTaskdeletion + Cloud Function comment/metadata updates). No Android app code changed.Independence verification: This PR modifies only
Task(deleted) andfunctions/*files. Confirmed no overlap with open drafts #164 and #165, which touchapp/,camera/,data/,diagnostics/, andbaselineprofile/.