Simplify DependencyTracker usage and enhance its performance and test coverage#18
Merged
Conversation
The three-method sequence (BuildDependenciesForTest, BuildRequestChain, OnTestExecuted) leaked ordering concerns into the runner. Now OnTestExecuted handles all of that internally and returns the request chain directly.
testUsesStatefulRefs previously re-parsed params JSON for every test in the dep chain on each call. Now each test's result is computed once and stored in usesStatefulRefs, so checking deps is a flat map lookup.
Consolidate four separate test functions into one for enhanced readability and extendability. Also extends coverage to include a known documented limitation of the dependency tracker when unrelated state mutation might leak into a request chain.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details included in commit messages.