-
Notifications
You must be signed in to change notification settings - Fork 4
Extend protocol to support testing callback interfaces #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
stringintech
wants to merge
5
commits into
main
Choose a base branch
from
callbacks
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
eb2572e
Report skipped tests in summaries
stringintech 1e6c1d8
Print less noise at lower verbosity
stringintech 06fc6bf
Add failed-test recap for runner output
stringintech c62440a
Extract refs from result and track them as ref creators
stringintech 7884d40
Extend protocol to support testing callback interfaces
stringintech File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| { | ||
| "$schema": "https://json-schema.org/draft/2020-12/schema", | ||
| "description": "Gets the height of a block tree entry", | ||
| "type": "object", | ||
| "additionalProperties": false, | ||
| "required": [ | ||
| "description", | ||
| "request", | ||
| "expected_response" | ||
| ], | ||
| "properties": { | ||
| "description": { | ||
| "$ref": "./shared.json#/$defs/NonEmptyText" | ||
| }, | ||
| "request": { | ||
| "type": "object", | ||
| "additionalProperties": false, | ||
| "required": [ | ||
| "id", | ||
| "method", | ||
| "params" | ||
| ], | ||
| "properties": { | ||
| "id": { | ||
| "$ref": "./shared.json#/$defs/TestCaseID" | ||
| }, | ||
| "method": { | ||
| "const": "btck_block_tree_entry_get_height" | ||
| }, | ||
| "params": { | ||
| "type": "object", | ||
| "additionalProperties": false, | ||
| "required": [ | ||
| "block_tree_entry" | ||
| ], | ||
| "properties": { | ||
| "block_tree_entry": { | ||
| "$ref": "./shared.json#/$defs/RefObject", | ||
| "description": "Block tree entry reference" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| "expected_response": { | ||
| "$ref": "./btck_block_tree_entry_get_height.response.json" | ||
| } | ||
| } | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As documented here, handlers might need to copy callback args to extend their lifetime; but right now this is only needed for
stateinbtck_ValidationInterfaceBlockChecked, a view into a stack-local.BlockCheckedis also the only callback with mixed ownership:blockarrives owned,statearrives as a short-lived view. A cleaner upstream contract might be to always pass object args as views and let consumers copy only when they need to outlive the callback - soblockwould becomeconst btck_Block*too?