[Feature] Breakpoints update - #708
Open
antoine4livre wants to merge 3 commits into
Open
Conversation
Export Size@studiometa/js-toolkit
Unchanged@studiometa/js-toolkit
|
`@studiometa/tailwind-config`
titouanmathis
force-pushed
the
feature/breakpoints-update
branch
from
August 16, 2026 19:58
ff1f399 to
dfbc093
Compare
Export sizeBundled per export with peer dependencies left external, dynamic imports excluded and the output minified; sizes are gzipped. @studiometa/js-toolkit
Unchanged (377)@studiometa/js-toolkit
@studiometa/js-toolkit-v4
|
Code ReviewRisk: Low — The default breakpoint names and thresholds are updated consistently in the main feature configuration and several documentation examples; fix the changelog artifact and remaining stale documentation before merging. Updates the default breakpoints from the former 1 issue(s) found:
Review usage: 73,637 in (57,095 cached) / 1,007 out tokens — $0.0162 (openrouter/openai/gpt-5.6-luna, thinking: low) Reviewed by @weareikko/code-review v0.9.5 for commit dfbc093. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
|
||
| - Deprecate `$parent`, `$children` and `$root` instance properties in favor of `$closest(name)` and `$query(name)` ([#694](https://github.com/studiometa/js-toolkit/issues/694)) | ||
|
|
||
| ||||||| parent of 74613a7a (Update changelog) |
There was a problem hiding this comment.
nitpick: Remove the leftover merge-conflict marker
The literal token ||||||| parent of 74613a7a (Update changelog) is present in the published changelog, leaving an unresolved merge-conflict artifact in the Markdown. Delete this line before merging.
Confidence: high.
Reviewed by @weareikko/code-review v0.9.5 for commit dfbc093.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #708 +/- ##
==========================================
- Coverage 97.17% 93.79% -3.38%
==========================================
Files 170 32 -138
Lines 4143 758 -3385
Branches 1151 319 -832
==========================================
- Hits 4026 711 -3315
+ Misses 106 41 -65
+ Partials 11 6 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
v3 mount benchmarksBase and head measured on this runner, alternating over 3 rounds each; every value is the median of the round medians. Running both sides on one machine is what removes cross-machine noise — a cached baseline from another runner would put it back. A move under 25%, or on a benchmark under 5 ms, is not reported as a change: it is inside the measured noise of a shared runner. No benchmark moved beyond the noise floor. Within noise (10)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
❓ Type of change
📚 Description
Update the default breakpoints according to our Tailwind config's custom breakpoints. We need to talk about the retro compatibility and migration of our old projects.
📝 Checklist