fix(input_window): disable dynamic height if min_height == max_height - #260
Merged
Conversation
Owner
|
This looks like a reasonable fix. I know there is none right now, but we should add a little bit of testing around the dynamic resize so we don't end up breaking it in the future |
Contributor
Author
I agree! which type of test would you prefer for it? replay/unit? |
Owner
|
I don't think you can replay the input behavior. Just a quick unit test. |
disrupted
force-pushed
the
disable-dynamic-height
branch
from
February 12, 2026 18:31
d826e9b to
e047fe4
Compare
disrupted
marked this pull request as ready for review
February 12, 2026 18:31
Contributor
Author
|
@sudo-tee done! added 2 basic unit tests for dynamic height enabled/disabled |
Owner
|
Looks good to me Thanks for the PR and the test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #253