feat(completion): handle symlinked directories in file completion - #339
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support for mentioning/adding files located under symlinked directories within the current working directory (fix for #336), primarily by changing how “inside cwd” is determined so that logical (non-resolved) paths can be accepted.
Changes:
- Update
util.is_path_in_cwdto allow relative paths that stay logically withincwdwithout resolving symlinks. - Adjust file completion to build an absolute path without explicitly resolving symlinks.
- Add unit tests for
util.is_path_in_cwd.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
lua/opencode/util.lua |
Adds a “logical path” check path for relative paths to support symlinked directories. |
lua/opencode/ui/completion/files.lua |
Changes how completion items compute full_path used when adding a file to context. |
tests/unit/util_spec.lua |
Adds new test cases for util.is_path_in_cwd. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
disrupted
pushed a commit
to disrupted/opencode-native.nvim
that referenced
this pull request
Jul 23, 2026
…do-tee#339) * feat(completion): handle symlinked directories in file completion * feat(util): support symlinked directories in is_path_in_cwd This should resolve sudo-tee#336
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should resolve #336