fix(renderer): scope shared-server events by session - #406
Merged
Conversation
Route renderer event subscriptions through explicit scope policies so global server events do not leak interactive prompts across sessions. Centralize request ownership checks in session_scope and reuse them from permission/question restore paths. Keep task child-session tool parts working when child events arrive before the parent task part is indexed. Fixes sudo-tee#405
Owner
|
This is actually an issue I encountered last week I was planning to look at. Thanks for beating me to it :) |
disrupted
pushed a commit
to disrupted/opencode-native.nvim
that referenced
this pull request
Jul 23, 2026
Route renderer event subscriptions through explicit scope policies so global server events do not leak interactive prompts across sessions. Centralize request ownership checks in session_scope and reuse them from permission/question restore paths. Keep task child-session tool parts working when child events arrive before the parent task part is indexed. Fixes sudo-tee#405
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Route renderer event subscriptions through explicit scope policies so global server events do not leak interactive prompts across sessions.
Centralize request ownership checks in session_scope and reuse them from permission/question restore paths. Keep task child-session tool parts working when child events arrive before the parent task part is indexed.
Fixes #405