feat(ui): inline floating input for Other option - #455
Conversation
|
This can help with #451 |
|
It looks great! I'll give it a try in about an hour or two. |
I really like it! But I'm not sure if this is related to this PR, but is our original interaction logic for multi-selection similar to the TUI? It seems that directly confirms the selection? and WinLeave drops typed input on any focus loss, my agent said that root cause is using WinLeave as cancel trigger when WinClosed/Esc already covers cleanup. @sudo-tee |
|
Not sure I follow here. WinLeave is only on the inline input element. I don;t think we support multi-selection yet in our imnplementation |
Sorry, I should have recorded a GIF, but when the input field is accidentally dismissed and then reopened, the original input is discarded. Perhaps this could be optimized? Multi-selection can be discussed later |
|
Oh I see. I will have a look. Thanks |
Save input buffer text on BufLeave and restore on next open, so partial input survives accidental focus changes.
|
I pushed a fix for the accidental dismiss. |
* feat(ui): inline floating input for Other option * feat(inline-input): preserve text across focus loss Save input buffer text on BufLeave and restore on next open, so partial input survives accidental focus changes.
2 participants
This PR introduce an inline input for answering the Other question inline.
@jensenojs
If you have a minute. I'd like your
input(pun intended 😅) on this.Does it work for you, do you think it's a proper implementation that we can use for the Permission
Deny