fix(ci): stop labeler overwriting org triage labels - #67
Merged
Conversation
actions/labeler replaces the entire label set in a single write, so running it in parallel with the org triage job let its snapshot race the triage labels and erase them on PUT (seen on PR #66, where the commit/maintainer labels vanished one second after being applied). Serialize the label job on triage so area labels layer on top of the org ones instead of overwriting them.
suiflex-bot
Bot
added
area: ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
labelandtriagejobs insuiflex.ymlrun in parallel onpull_request_target, and both write labels.actions/labelerreplaces the whole label set in onesetLabels(PUT) call based on a snapshot read at start, so it can erase the org labels (bot,maintainer,commit: *,needs: conventional commit) that the triage job applied seconds earlier.maintainer+ 4commit: *labels applied at 17:24:29Z, then unlabeled at 17:24:30Z by the labeler's PUT, leaving only thearea: *labels.Changes
labeljob now declaresneeds: triageso its read happens after the org labels are applied; area labels layer on top instead of overwriting.needsaway.Test plan
ruby -ryaml).commit: */maintainerandarea: *labels survive.