Improve psql wrapper script - #820
Open
jmaupetit wants to merge 2 commits into
Open
Conversation
Make psql script more versatile and avoid unnecessary environment variables parsing.
jmaupetit
force-pushed
the
improve-psql-dev
branch
from
September 4, 2026 15:52
e6d4b67 to
36feddf
Compare
jmaupetit
commented
Sep 4, 2026
They are not used in the Makefile and injected in the running container, there is no need to declare them explicitly.
jmaupetit
force-pushed
the
improve-psql-dev
branch
from
September 4, 2026 16:39
36feddf to
d10b75e
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
The
bin/psqlwrapper script can be used to run thepsqlcommand using a TTY or not depending on whether we need the REPL or to execute a SQL script. Also, getting environment variable from their definition file is not necessary as they are already defined in the running container.Proposal