skill: make Codex inbox monitor idle-token free - #73
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4ceeee70ac
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 64359e860f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Distinct-family review trace for exact stacked head
If rebasing after PR #70 changes the final head, this verdict will be treated as stale and the exact-head review gate will run again before merge. |
d075e61 to
1f2fb48
Compare
a3cd50b to
6cd6700
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8e9279edf5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c865cf1bf9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b5d79f5f05
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Final independent exact-head governance evidence: request |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4281a2528a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Superseding final review evidence after integrating the two current-head GitHub findings: request |
|
Final independent exact-artifact review evidence
The reviewer confirmed the 11 requested contracts: goal-free new Codex starts, Minor adjudication: both findings concern the non-normative historical Strongest counterargument recorded by the reviewer: enforcement is primarily |
1 participant
Summary
agent-collab4.5.3.leased local process at its existing 10-second interval, but create no new
Codex goal or recurring model-level continuation for liveness.
turns. Legacy cleanup requires closed same-turn structured-transcript proof
and completes a goal only after the host proves the exec survives
independently.
degraded_no_event_wakewhen the local process is live but the hosthas not proven an event-driven model wake, or
legacy_goal_detach_unavailablewhen safe legacy detachment is unproven.lifecycle mutation, and return
stop_incomplete_legacy_goalinstead ofclaiming a full stop when the host cannot safely bind and end the old goal.
armed, singletoninspection, and continuation-status contracts.
state.
Exact final artifact
1687f89736f0ed4a862fed8f10893a0fb9c58b4d(main, merged PR runtime: separate broker activity from persistence #70)2753afb8c6bdd482e70b206c069aca00c222ec36125521a1050e6365f166e1350b5d195af41ae39b7a7991326674cf51ee912fe2Boundary declaration
absolute path, retired package tree, downloader, or post-install hook is
included.
plugin.
mutated by this source change.
Generated and release surfaces
SKILL.mdfiles are in parity.changelog.d/fragment is present; generatedCHANGELOG.mdremains unchanged under the fragment-only convention.
Verification
python3 -B scripts/build_skills.py --checkpython3 -B scripts/build_marketplace.py --checkpython3 -B scripts/build-changelog.py --dry-runpython3 -B scripts/check_release_consistency.pypython3 -B scripts/secret_scan.py— 330 source files cleanpython3 -B scripts/check-public-export-safety.py --active-treepython3 -B scripts/check-public-export-safety.py --active-tree --historygit diff --checkbase; SHA-256
d4765bfc8ea2240f8886250ec7c81fef40f3c175e2b0d04af2b6a0811ea55aecIndependent exact-artifact review
RECONSIDER: found that the initial Codex-only wakepolicy had leaked into shared lifecycle semantics and that tripwire coverage
was incomplete. The valid findings were integrated with RED/GREEN commits.
agent-collab-pr73-exact-grok-review-20260728-round2, xAI/Grok 4.5,read-only governance authority, typed
status=ok, severityNone.Codex-only degradation on startup and busy-lease adoption, goal-free
zero-idle behavior, the bounded legacy tripwire, conditional model/effort
advice, and focused regression coverage.
git range-diff, but changed the commit identity and binary diff digest.The stacked-head approval is therefore superseded.
agent-collab-pr73-final-exact-grok-review-20260728-2, xAI/Grok 4.5,read-only governance authority, typed
status=ok: found that the legacyfingerprint and goal/exec detach safety were underspecified, the shared
already_armeddescription needed its Codex exception, and tests neededexact positive and negative legacy fixtures. All valid findings were
integrated in signed RED/GREEN commits.
old skill required semantic fields but did not prescribe one literal
objective paragraph. The text-only fingerprint was replaced by a closed
same-turn structured-transcript proof over the original skill read,
get_goal, explicit-start state,create_goal, canonical exec launch,retained exec ID, and startup anchors; transcript prose is untrusted data.
agent-collab-pr73-final-exact-grok-review-20260728-3, xAI/Grok 4.5,read-only governance authority, typed
status=ok: found that safe legacydetach failure left later empty turns and explicit-stop handling
underspecified, while public wording overclaimed the upgraded-session path.
All valid findings were integrated with an every-turn no-poll/no-mutation
decision table, bounded transcript reads, explicit legacy-goal stop results,
honest release wording, and RED/GREEN regression coverage.
agent-collab-pr73-final-exact-grok-review-20260728-4, xAI/Grok 4.5,read-only governance authority, typed
status=ok: its claimed missingSeen-files pathassertion was contradicted by the exact Codex startupbullet and rejected. Its valid stop-authority and stale-design findings were
integrated: stop now targets only monitor-bound retained exec identifiers,
never other session execs, and the design requires fail-closed handling on
every legacy continuation.
agent-collab-pr73-final-exact-grok-review-20260728-5, xAI/Grok 4.5,read-only governance authority, reviewed head
e690e6b59ba3aebe6376d222d44403ab7525e6eband artifact1dbb8561b8f2ea530ade46805d32e027c2a8908f8336efa020168cdb426251b4;typed
status=okwith valid raw JSONL severityNone.gaps: the old skill used
statusduring automatic activation, not onlyexplicit
start, and a structurally matching turn still needed the oldobjective's session, scope, routing-exclusion, and no-scheduling semantics.
Both were integrated as trigger-matched state alternatives and necessary
objective fields with fail-closed table cases and RED/GREEN coverage.
agent-collab-pr73-final-exact-grok-review-20260728-6, xAI/Grok 4.5,read-only governance authority, reviewed head
4281a2528a26f4a1f8f8b64530fb419afa670ba5and artifactb813e51693661b91934a4f86a76554bb46431214e09135a0106ea97d081eaff6;typed
status=okwith valid raw JSONL severityNone.retained control did not prove the monitor was still running at detach time.
The valid finding was integrated: safe detach now requires attached positive
current liveness for the exact retained exec or lease-owning process;
absent, stale, ambiguous, or terminal evidence leaves both lifecycles
untouched without a poll.
synchronous read-only direct CLI with tools disabled and no session
persistence, outside the broker/coordinator path — reviewed head
2753afb8c6bdd482e70b206c069aca00c222ec36and the exact 109,860-byteartifact
125521a1050e6365f166e1350b5d195af41ae39b7a7991326674cf51ee912fe2;typed verdict
APPROVEwith zero Critical and zero Important findings.historical implementation plan retains an earlier “first empty
continuation” phrase and an illustrative RED-test snippet, while the
normative skill, design, generated skill, and committed regression tests
consistently require the stronger every-empty-continuation rule. Reviewed
source bytes were left unchanged.
Review and post-condition
Tier 2: this is a compatible user-visible skill/policy change. Merge only after
the final independent-family exact-head review, required CI, and a
MERGE-ELIGIBLElocal compliance result. Stop at source merge: do not tag,release, install, restart Codex, or mutate the live monitor in this task.
Compliance trace
author: codex
standing_directives: read and followed public AGENTS.md, docs/public-governance.md, generated parity, fragment-only changelog, signed-commit, exact-head validation, and public-source boundary requirements
tier: 2
cross_check: PROCEED - Anthropic Claude Opus 4.8 high-effort read-only direct exact-artifact review APPROVE with zero Critical or Important findings for head 2753afb, 109860 bytes, SHA-256 125521a1050e6365f166e1350b5d195af41ae39b7a7991326674cf51ee912fe2; two Minor historical-plan documentation findings adjudicated nonblocking
post_condition: stop at source merge with no tag, release, installed-plugin refresh, Codex restart, or live-monitor mutation
mcp_coverage_gap: NONE
contributor_rights: OWNER-AUTHORED
operator_reserved: no